Added changes for IPv6 structure #1606
Open
+268
−365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peanball
reviewed
Jun 17, 2025
assets/php/htdocs/.htaccess
Outdated
| @@ -0,0 +1,2 @@ | |||
| RewriteEngine On | |||
| RewriteRule ^(ipv4-test|ipv6-test|dual-stack-test)$ $1.php [L] | |||
There was a problem hiding this comment.
you could technically rewrite to:
RewriteRule ^(ipv4|ipv6|dual-stack)-test$ ip-test.php?target=$1 [L]This will then translate /ipv6-test to a call to ip-test.php?target=ipv6, etc.
Then you can have a single file, and the same type of map you have like in the other tests. Instead of the request path you'd base it on the value of the $_GET["target"] parameter in PHP.
There was a problem hiding this comment.
Thanks for the provided solution. I've added the changes it and it worked.
Milena-Encheva
changed the title
peanball
reviewed
Jun 18, 2025
assets/php/htdocs/ip_functions.php
Outdated
| @@ -0,0 +1,12 @@ | |||
| <?php | |||
|
|
|||
| function fetchIpAddress($url) { | |||
There was a problem hiding this comment.
you could now fold in this function into ip-test.php and remove the include there.
There was a problem hiding this comment.
Much better. Done. Thank you.
peanball
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key Updates:
Direct Output from Public Sites:
The main difference in the approach is that the apps now directly return the output from public Ips without additional processing for IP determination or success validation.
Go test Changes:
The Go app tests each buildpack listed in the script using the three main scenarios: IPv4, IPv6, and Dual-stack. I have created new function CurlAppWithStatusCode since our previously used function did not obtain the HTTP status code.
The updated function in the
app_curler.gonow modifies the curl command to retrieve both the response body and the HTTP status code. We utilize this output in the ginko tests by separating the IP address from the status code. Subsequently, we verify that the IP aligns with the scenario being validated and that the status code indicates success (HTTP 200).